Conversation
Collaborator
y4my4my4m
commented
Aug 25, 2023
y4my4my4m
commented
- Skynet
- Full chat application for 3.5 / 4.0
- Basic implementation for gpt2 / gpt3
- Middleware server example config file / instructions
y4my4my4m
requested review from
GutPuncher,
Midnoclose,
TempleProgramming,
doodayev,
mintsuki and
slendidev
Collaborator
Author
|
Update and make compatible with the latest openai api endpoints |
slendidev
requested changes
Feb 9, 2025
Comment on lines
+20
to
+28
| U8 *StrChr(U8 *Str,U8 Pivot) | ||
| { | ||
| //U8 *Orig=Str; | ||
| while (*Str!=Pivot&&*Str!=0)Str++; | ||
| if (*Str==Pivot) return Str; | ||
| else return 0; | ||
| } | ||
| U8* RemoveBeforeJSON(U8 *input) { | ||
| U8 *jsonStart = StrChr(input, '{'); |
Collaborator
There was a problem hiding this comment.
StrChr is only used once here. Just put it in RemoveBeforeJSON.
Collaborator
There was a problem hiding this comment.
Also, why not just use StrFind?
Comment on lines
+63
to
+64
| //SysLog(payload); | ||
|
|
| responseLength += TCPSocketReceive(sock, responseBuf + responseLength, bufferSize - responseLength - 1); | ||
| responseBuf[responseLength] = 0; | ||
| } | ||
| //SysLog(responseBuf); |
| } | ||
|
|
||
| U8 *completion = contentEntry->string_data; | ||
| //SysLog(completion); |
| Free(msg); | ||
| } | ||
|
|
||
| U8 *currentUserMsg = StrPrint(NULL, "{\"role\": \"user\",\"content\": \"%s\"}", message); |
Collaborator
There was a problem hiding this comment.
You should sanitize the user input.
Comment on lines
+20
to
+26
| U8 *StrChr(U8 *Str,U8 Pivot) | ||
| { | ||
| //U8 *Orig=Str; | ||
| while (*Str!=Pivot&&*Str!=0)Str++; | ||
| if (*Str==Pivot) return Str; | ||
| else return 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.