Add pre-commit hook to remove cursors.#96
Open
slendidev wants to merge 1 commit intoZeal-Operating-System:masterfrom
Open
Add pre-commit hook to remove cursors.#96slendidev wants to merge 1 commit intoZeal-Operating-System:masterfrom
slendidev wants to merge 1 commit intoZeal-Operating-System:masterfrom
Conversation
Midnoclose
reviewed
Feb 25, 2023
Collaborator
Midnoclose
left a comment
Midnoclose
left a comment
There was a problem hiding this comment.
Personally, I believe that the cursor should be removed by Zeal during the sync script so as to not rely on a python dependency.
Collaborator
Author
|
It does not rely on a Python dependency if the contributor doesn't want to use the actual hook. This is totally optional. I mean you need to install the hook after all with the appropriate hook. |
This patch adds a pre-commit hook specifically for *NIX systems to remove the cursor byte from all files under `src/`. The reason why I chose python is because it is assumed that most *NIX systems already come with it pre-installed. Signed-off-by: xSlendiX <slendi@socopon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a pre-commit hook specifically for *NIX systems to remove the cursor byte from all files under
src/.The reason why I chose python is because it is assumed that most *NIX systems already come with it pre-installed.