Skip to content

Fix SQL Injection Vulnerability by Parameterizing the customerId in Scala's CustomerController. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeropath-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SQL Injection Vulnerability by Parameterizing the customerId in Scala's CustomerController. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/controllers/CustomerController.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,11 @@ class CustomerController @Inject() (ws: WSClient, config: Configuration) extends
// get /rawcustomers/{customerId}
def getRawCustomer(customerId: String) = Action {
if (null == customerId) throw new InvalidCustomerRequestException
val sqlQuery = "SELECT first_name, last_name FROM customer WHERE id = " + customerId
val sqlQuery = "SELECT first_name, last_name FROM customer WHERE id = :id"
val rawSql = RawSqlBuilder.parse(sqlQuery).create
val query = CustomerController.db.find(classOf[Customer])
query.setRawSql(rawSql)
query.setParameter("id", customerId)
val customer = query.findList.asScala
if (null == customer || customer.isEmpty) throw new CustomerNotFoundException
Ok(Json.toJson(customer))
Expand Down