Fix meson setup failure not exiting build script when it should#4
Merged
Fix meson setup failure not exiting build script when it should#4
Conversation
If somehow the `meson setup` command were to fail, the prior verson of this script did not error at the `if [ $meson_exit_code -ne 0 ]; then` step.
…nd compile failures
checks to see if the setup command fails by not cloning the test repository (currently the kernel)
…he specific case we want instead of excluding extra ones we don't want
…=false while clone_repo=false
… for Meson setup and compile failures` since it's unrelated to this PR
SizzinSeal
reviewed
Mar 20, 2025
Member
SizzinSeal
left a comment
There was a problem hiding this comment.
LGTM, but I want @meisZWFLZ to review this before it gets merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3