Open
Conversation
Updated help text for the '-org' argument and removed nargs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework of the command-line interface
Implementation of the ARTSArgumentParser as a separate class that extends argparse.ArgumentParser.
Optional parameters are divided into groups for more clarity.
parse_input_orgs, minor edit and alternative implementation
Special treatment for lists with only one element is not necessary here, so I have removed the corresponding lines of code.
The purpose of this function seems to be to parse comma-separated lists and give the elements unique names by appending numbers. I have included an alternative implementation that would ensure that all elements with the same name are given their own sequential numbering. However, parse_input_orgs() is only applied to the input from ARTS anyway. This should consist of file paths, which are unique anyway.
Best, Simon