Skip to content

Conversation

@Neotamandua
Copy link
Member

@Neotamandua Neotamandua commented Oct 13, 2025

This pull request updates the GitHub Actions workflow configuration for Rust formatting, linting, and dependency checks. The main goals are to modernize the workflow, improve caching for faster runs, and use updated actions for better reliability.

Workflow modernization and improvements:

  • Updated all jobs (rustfmt, clippy, and deny) to use newer versions of GitHub Actions (actions/checkout@v4 and EmbarkStudios/cargo-deny-action@v2) for improved performance and compatibility.
  • Switched Rust toolchain installation to use dtolnay/rust-toolchain action for both nightly and stable toolchains, simplifying setup and ensuring consistency.

Clippy job enhancements:

  • Added a step to cache the Cargo registry and build artifacts, speeding up subsequent workflow runs.
  • Configured Clippy to run on all targets and features for more comprehensive linting coverage.

General improvements:

  • Added descriptive job names for better readability in the Actions UI.
  • Updated the cargo-deny job to specify the Rust version explicitly, ensuring compatibility.

@Neotamandua Neotamandua marked this pull request as draft October 13, 2025 15:44
@Neotamandua Neotamandua force-pushed the neotamandua/update_cargo branch 7 times, most recently from b77469d to cface0c Compare October 13, 2025 16:24
@Neotamandua Neotamandua changed the title Fix cargo deny yanked crate Update workflows & cargo lockfile Oct 13, 2025
@Neotamandua Neotamandua marked this pull request as ready for review October 13, 2025 16:31
@Neotamandua Neotamandua force-pushed the neotamandua/update_cargo branch from b9e76cd to 801ea24 Compare October 13, 2025 16:34
@Neotamandua Neotamandua requested a review from Copilot October 13, 2025 16:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates GitHub Actions workflow configuration to use more recent action versions and improve the CI pipeline structure with better caching and clearer step names.

  • Updated action versions from v3 to v4 for checkout and other actions
  • Improved workflow structure with descriptive job and step names
  • Added Cargo registry caching to improve build performance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Neotamandua Neotamandua force-pushed the neotamandua/update_cargo branch from 801ea24 to df3d5e1 Compare October 14, 2025 16:21
@Neotamandua Neotamandua force-pushed the neotamandua/update_cargo branch from df3d5e1 to c1f9dbc Compare October 14, 2025 16:24
Copy link
Member

@SplittyDev SplittyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Neotamandua Neotamandua merged commit 428bb5b into development Oct 15, 2025
6 checks passed
@Neotamandua Neotamandua deleted the neotamandua/update_cargo branch October 15, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants