Skip to content
This repository was archived by the owner on Aug 22, 2024. It is now read-only.

Conversation

@Craaftx
Copy link

@Craaftx Craaftx commented Apr 6, 2018

ℹ️ Link to issue #13

TODO :

  • authMiddleware line 109 should be an async function ✔
  • rewrite promise .then using await ✔
  • callback should be called with await
  • line 72, 73 use await/async ✔

@Craaftx
Copy link
Author

Craaftx commented Apr 6, 2018

I think it's done.

But for this point : (callback should be called with await), I didn't find on the net answers about the fact that an Async function can not execute into the parameters of a function.
Like in this case :

zoauthRouter.js - line 70
[...]
root.methods[method].call(
      p,
      async (req, res, next) => {
        await root.authMiddleware(req, res, next, authCb);
      },
[...]

So i think it's ok like this.

What do you think @willdurand ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant