correct type bounds for base signing provider#282
Draft
iaik-jheher wants to merge 3 commits intodevelopmentfrom
Draft
correct type bounds for base signing provider#282iaik-jheher wants to merge 3 commits intodevelopmentfrom
iaik-jheher wants to merge 3 commits intodevelopmentfrom
Conversation
JesusMcCloud
force-pushed
the
development
branch
2 times, most recently
from
ee39ea6 to
62049e4
Compare
iaik-jheher
force-pushed
the
fix/signer-bounds
branch
from
899b354 to
42f19cd
Compare
iaik-jheher
force-pushed
the
fix/signer-bounds
branch
from
42f19cd to
c493c39
Compare
JesusMcCloud
requested changes
Sep 10, 2025
Collaborator
JesusMcCloud
left a comment
JesusMcCloud
left a comment
There was a problem hiding this comment.
Well, if the tests can be made to work again, I'll re-review
JesusMcCloud
force-pushed
the
development
branch
from
3dcddf0 to
82e036e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlatformSigningProvidershould requirePlatformSigningKeyConfigurationBase, butSigningProvidershould only requireSigningProviderSigningKeyConfigurationBase.