Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CI workflow to support building and using EROFS tools for the erofs-snapshotter project.
- Introduces a step to build and install
erofs-utilsfrom source on non-ARM runners - Adds a step to load the EROFS kernel module when supported
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:402
- Consider adding
--no-install-recommendstoapt-get installto avoid pulling in unnecessary packages and reduce image size.
sudo apt-get install -y git make gcc libz-dev liblz4-dev libfuse-dev autoconf libtool pkg-config uuid-dev
Comment on lines
+409
to
+411
| git clone https://github.com/erofs/erofs-utils.git | ||
| cd erofs-utils | ||
| git checkout v1.8.5 |
There was a problem hiding this comment.
Use a shallow clone and branch flag to speed up CI, e.g., git clone --depth 1 --branch v1.8.5 https://github.com/erofs/erofs-utils.git and remove the separate git checkout step.
Suggested change
| git clone https://github.com/erofs/erofs-utils.git | |
| cd erofs-utils | |
| git checkout v1.8.5 | |
| git clone --depth 1 --branch v1.8.5 https://github.com/erofs/erofs-utils.git | |
| cd erofs-utils |
aadhar-agarwal
added a commit
that referenced
this pull request
Nov 11, 2025
# This is the 1st commit message: Add dmverity support to erofs snapshotter using veritysetup cli Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com> # This is the commit message #2: Add dmverity support to the erofs snapshotter Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com> # This is the commit message #3: Align changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.