fix: Check if unit is player before rendering tooltip#115
Open
danlemmond wants to merge 1 commit intoaaronma37:masterfrom
Open
fix: Check if unit is player before rendering tooltip#115danlemmond wants to merge 1 commit intoaaronma37:masterfrom
danlemmond wants to merge 1 commit intoaaronma37:masterfrom
Conversation
The current tooltip implementation does a string check against the name returned from GetUnit but this can lead to players who have named themselves after NPCs having creature data rendered in their tooltips Instead, run a UnitIsPlayer check prior to rendering any tooltip data that returns immediately if the unit is a player
Author
|
I also added |
Author
|
Here's an example of a player w/ an NPC name incorrectly having deathlog tooltip data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current tooltip implementation does a string check against the name returned from GetUnit but this can lead to players who have named themselves after NPCs having creature data rendered in their tooltips
Instead, run a UnitIsPlayer check prior to rendering any tooltip data that returns immediately if the unit is a player