Skip to content

Increase padding for token generation #454

Open
jessikad-google wants to merge 1 commit intomainfrom
jessikad/increase_clock_padding_jwt
Open

Increase padding for token generation #454
jessikad-google wants to merge 1 commit intomainfrom
jessikad/increase_clock_padding_jwt

Conversation

@jessikad-google
Copy link

We are encountering issues with cloud run githup app credentials for the GMA retry cloud run job.

Increasing from 30 seconds to 60.

"failed to list deliveries: failed to list deliveries: GET https://api.github.com/app/hook/deliveries?cursor=v1_xxxxxxx&per_page=100: 401 'Expiration time' claim ('exp') must be a numeric value representing the future time at which the assertion expires []"

… issues with cloud run githup app credentials
@jessikad-google
Copy link
Author

Lint issues are not with the file included in the PR ?

@jessikad-google jessikad-google marked this pull request as ready for review December 16, 2025 20:44
@jessikad-google jessikad-google requested a review from a team as a code owner December 16, 2025 20:44
// where the JWT we issue looks like it is coming from the future when it gets
// to GitHub
iat := time.Now().UTC().Add(-30 * time.Second)
iat := time.Now().UTC().Add(-60 * time.Second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message you got was due to EXP being in the past, not due to iat being in the future.

At least that is how I read it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments