feat: improve oauth support and openapi v3.1 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced README.md to provide clearer instructions and details about the sample application, including OAuth 2.0 integration and transport modes. - Introduced a new Worker class to manage OpenIddict application setup and ensure database creation. - Updated appsettings files to include BaseUrl and OAuthBaseUrl configurations for development and production environments. - Modified sample-api.json to reflect a more relevant API structure and removed unused endpoints. - Added InMemoryTokenStore for testing purposes, allowing secure token storage during integration tests. - Implemented OAuth metadata and middleware tests to ensure proper handling of authentication flows and token validation. - Created MockMcpContextAccessor to facilitate testing by simulating context access. - Refactored OAuth authentication tests to utilize the new token store and context accessor. - Developed OpenApiOAuthParserTests to validate the parsing of OpenAPI documents for OAuth configurations. - Established a comprehensive refactoring plan for the MCPify authentication system, focusing on core abstractions, secure persistence, and robust OAuth 2.0 implementation.
…fallback; update README for troubleshooting guidance
…n and decryption functionality
…ADME; enhance service-to-service authentication guidance
…traction; add unit tests for OpenApi provider functionality - support safe downgrade openapi version 3.1 to 3.0
…ade logic Fallback Mechanism: Updated ParseWithFallback to catch general OpenApiException (e.g., "Cannot create scalar value"), ensuring the downgrade logic triggers even when the reader crashes on valid 3.1 syntax. Recursive Schema Transformation: Added DowngradeSchemaFeatures to programmatically transform OpenAPI 3.1 constructs into 3.0 compatible equivalents: Nullable Types: Converts type: ["string", "null"] arrays to type: "string", nullable: true. Exclusive Ranges: Converts numeric exclusiveMinimum/exclusiveMaximum values to the 3.0 boolean format (minimum: N, exclusiveMinimum: true). Const Values: Transforms const values into single-value enum arrays. Examples: Maps the 3.1 examples array to the 3.0 example field. Cleanup: Explicitly removes 3.1-only root properties (jsonSchemaDialect, webhooks) to prevent validation warnings.
…n; add test data file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coverage for file-based loading.
discoverable.