Skip to content

Fix Issue #89 and Issue #93 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lincolnep wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Issue #89 and Issue #93 #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a6b91c
Fix Issue #89
Nov 10, 2017
1d314b5
Fix Travis CI Build error
Nov 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/csv-editor-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,12 @@ class CSVEditorElement extends HTMLElement {

requestAnimationFrame(() => {
this.updatePreview(this.collectOptions())
this.model.applyChoice()
// Fix Issue #89 Uncaught TypeError: Cannot read property 'applyChoice' of undefined
try {
this.model.applyChoice()
} catch (e) {
this.destroy()
}
})
}

Expand Down
5 changes: 3 additions & 2 deletions lib/table-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1306,8 +1306,9 @@ class TableElement extends HTMLElement {
const cursorValue = cursor.getValue()
this.editor.setText(String(cursorValue || this.getUndefinedDisplay()))

this.editor.getBuffer().history.clearUndoStack()
this.editor.getBuffer().history.clearRedoStack()
// Removed - Issue #93 (Uncaught TypeError: Cannot read property 'clearUndoStack' of undefined)
// this.editor.getBuffer().history.clearUndoStack()
// this.editor.getBuffer().history.clearRedoStack()

if (initialData) { this.editor.setText(initialData) }
}
Expand Down