Compatibility with Node.js#9
Open
zamadatix wants to merge 1 commit intoabeisgoat:masterfrom
zamadatix:patch-1
Open
Compatibility with Node.js#9zamadatix wants to merge 1 commit intoabeisgoat:masterfrom zamadatix:patch-1
zamadatix wants to merge 1 commit intoabeisgoat:masterfrom
zamadatix:patch-1
Conversation
Per the discussion on Reddit from /u/daxxcqb https://www.reddit.com/r/javascript/comments/5h6ng1/%E0%B2%A0_%E0%B2%A0js/daxxcqb/ change "window.console.warn" to "self.console.warn" for compatibility with node.
|
This will not work @zamadatix (I am /u/jkmonger who posted the fix on reddit). You need to keep the bottom line the same and only change the references to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the discussion on Reddit from /u/daxxcqb https://www.reddit.com/r/javascript/comments/5h6ng1/%E0%B2%A0_%E0%B2%A0js/daxxcqb/ change "window.console.warn" to "self.console.warn" for compatibility with node.