Open
Conversation
Owner
|
Thanks @lubbo for implementing this feature and providing it via this pull request. While I find this feature really useful, the implementation would produce duplicate files in the different folders ("Originals"/"Derived"/"Current"). The philosophy of the PhotosExporter is to use hard links for files which are the same as much as possible, to save disk space. If you convert a heic to jpg in the "Originals" folder, the same heic to jpg conversion is applied for the "Derived" folder and to the "Current" folder, instead of creating hard links to the same jpg file. Would you like to modify your code in this direction? I would appreciate to integrate it then into the master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may be useful to always export .jpg...
I'm using Plex photo (shame on me!) and it doesn't support .heic