Open
Conversation
Fixed bug, return incorrect structure in removing.
abhiscripts
reviewed
Dec 11, 2021
Owner
abhiscripts
left a comment
abhiscripts
left a comment
There was a problem hiding this comment.
In todoReducer the todo value is already assigned in object format for REMOVE_TODO. Why you want to create a state as object of object line {todos: {todos : []}.
Author
|
Oh, sorry my bad, I just notice it. That because I wrote code as you did on youtube, but I found that when I remove item, it return todos object instead of {todos: todos: []}. I think I might miss that object format on REMOVE_TODO part. You may reject this PR. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug, return incorrect structure in removing.