Spec: specify that the delta bases are only MESSAGE_CREATEs #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most obviously, not META occupancy etc (those obviously have no payloads and would otherwise break the delta stream) also exempt summaries, updates, and deletes, which (a) are (at least for now) not order-preserved relative to the create stream from a single publisher, and (b) are probably modifying (or deleting) old messages. Honestly, mutable messages and deltas are an unlikely combination -- people using deltas are probably just using creates as updates, sending a large constantly-changing data object as a stream of new messages, so probably aren't going to want to mutate old payloads. But if someone does have a usecase for it, this seems to me like the most sensible approach.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most obviously, not META occupancy etc (those obviously have no payloads and would otherwise break the delta stream)
I've decided to also exempt summaries, updates, and deletes, which (a) are (at least for now) not order-preserved relative to the create stream from a single publisher, and (b) are probably modifying (or deleting) old messages. Honestly, mutable messages and deltas are an unlikely combination -- people using deltas are probably just using creates as updates, sending a large constantly-changing data object as a stream of new messages, so probably aren't going to want to mutate old payloads. But if someone does have a usecase for combining the two, this seems to me like the most sensible approach.
(Skipping updates & deletes for delta generation is not done serverside yet; if we have consensus on this approach I'll make that change there before merging this).
Any thoughts @ttypic @lawrence-forooghian ?