Skip to content

Conversation

@VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Jul 11, 2025

No description provided.

@VeskeR VeskeR added the live-objects Related to LiveObjects functionality. label Jul 11, 2025
@github-actions github-actions bot temporarily deployed to staging/pull/345 July 11, 2025 06:07 Inactive
@VeskeR VeskeR force-pushed the objects-operation-application branch 2 times, most recently from 6524bc0 to 0aa15d6 Compare September 5, 2025 08:22
@VeskeR VeskeR force-pushed the objects-features-idl branch from 38a7dfa to 875d7ac Compare September 5, 2025 08:27
class RealtimeObjects: // RTO*
getRoot() => io LiveMap // RTO1

class LiveObject: // RTLO*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class LiveObject: // RTLO*
class BaseRealtimeObject: // RTLO*

Since both LiveMap and LiveCounter extend this class and are part of RealtimeObjects, it makes sense to name the class BaseRealtimeObject.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, we agreed to avoid using LiveObject/LiveObjects in the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we agreed to not use term "LiveObjects" (plural) in the code specifically when talking about the feature "Objects".

"LiveObject" (singular) is a name for any "live object" - "live map", "live counter", "live list" (in the future)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is way easier to call something a "live object" (as we do in our conversations) and refer to it as "LiveObject" in the spec.
Since it also looks like that it shouldn't be necessary to expose LiveObject type to the public (kotlin and - and swift too I believe - implementations don't expose it) I'd prefer we stick to a simple name in the spec

Copy link
Collaborator

@sacOO7 sacOO7 Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then better if we call it BaseLiveObject or BaseObject since it's extended by LiveMap, LiveCounter and not exposed externally. wdyt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But... why? I don't see a clear reason to change it. If it's not a public type then the name itself is not that important, and LiveObject type name accomplishes what we need it to do in the spec. And if it is exposed publicly (which it currently is in ably-js) we can't just change the name in the spec as we would also need to update ably-js implementation.

I really don't want to go through all spec PRs and update the LiveObject name to something else given it does what it need to right now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, since it's an internal type, we can ignore the naming convention.

@VeskeR VeskeR requested a review from sacOO7 September 5, 2025 11:20
Copy link
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VeskeR VeskeR force-pushed the objects-operation-application branch from 0aa15d6 to 84fc685 Compare September 8, 2025 08:28
Base automatically changed from objects-operation-application to main September 8, 2025 08:29
VeskeR and others added 2 commits September 8, 2025 09:30
Co-authored-by: Lawrence Forooghian <53756884+lawrence-forooghian@users.noreply.github.com>
@VeskeR VeskeR force-pushed the objects-features-idl branch from 875d7ac to 7ccb26d Compare September 8, 2025 08:30
@VeskeR VeskeR merged commit 98146a2 into main Sep 8, 2025
2 checks passed
@VeskeR VeskeR deleted the objects-features-idl branch September 8, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

live-objects Related to LiveObjects functionality.

Development

Successfully merging this pull request may close these issues.

4 participants