Conversation
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
JonoYang
left a comment
JonoYang
left a comment
There was a problem hiding this comment.
Thanks, I left some comments about creating test files
|
|
||
| def test_collect_links_and_artifact_timestamps_repo_maven_apache_org(self): | ||
| # https://repo.maven.apache.org/maven2 | ||
| text = """ |
There was a problem hiding this comment.
The html code should be in individual test files, then we use them like this https://github.com/aboutcode-org/purldb/blob/main/packagedb/tests/test_api.py#L220
There was a problem hiding this comment.
Moved html code to individual test files.
| return f"""\ | ||
| Collect PackageURLs from Maven ({commit_batch}/{total_commit_batch}) | ||
|
|
||
| Tool: {tool_name}@v{VERSION} |
There was a problem hiding this comment.
use settings.PURLDB_VERSION here
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
|
@keshav-space I noticed you’ve already done some refactoring work. The changes in this PR conflict with that effort and can’t be merged directly into |
|
Closing this as a new PR for the same issue is created at #805 |
2 participants
Ref #630
mine_maven.pypipeline andmaven_crawler.pymaven_crawler.pyget_classifier_from_artifact_url()