Skip to content

Add Lua rockspec package handler for LuaRocks dependencies#4743

Open
SLASH217 wants to merge 8 commits intoaboutcode-org:developfrom
SLASH217:support_rockspec
Open

Add Lua rockspec package handler for LuaRocks dependencies#4743
SLASH217 wants to merge 8 commits intoaboutcode-org:developfrom
SLASH217:support_rockspec

Conversation

@SLASH217
Copy link

@SLASH217 SLASH217 commented Feb 13, 2026

Add Lua rockspec package handler for LuaRocks dependencies

Fixes #3526

Changes

  • Added RockspecHandler class for .rockspec file detection
  • Implemented RockspecParser using Lua AST parsing with luaparser library
  • Extracts package metadata: name, version, description, license, homepage_url, vcs_url (non-exhaustive list)
  • Integrated handler into APPLICATION_PACKAGE_DATAFILE_HANDLERS registry
  • Added 23 comprehensive unit and integration tests
  • Fixed dead documentation links in CONTRIBUTING.rst

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Prashanna Dahal prashanna217@gmail.com

Prashanna Dahal added 5 commits February 13, 2026 14:04
Implement base handler class and Lua rockspec parser
using luaparser for AST-based dependency extraction.

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>
Extract package metadata and dependencies from
rockspec files with version specification parsing.

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>
* Test parser with real Kong rockspec file
* Test handler integration with patterns

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>
Register handler in APPLICATION_PACKAGE_DATAFILE_HANDLERS
to enable automatic .rockspec file detection.

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>
* Update contributing-docs link to new structure
* Ensure both documentation links work correctly
* Point to getting-started/contribute path

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>
Change luaparser from == to match project's version pinning pattern:
* requirements.txt: luaparser==1.4.3 (exact pinning)
* setup.cfg: luaparser == 1.4.3 (exact pinning)

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>
Prashanna Dahal added 2 commits February 14, 2026 17:47
Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>
- This was causing a test to fail in CI/CD
Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for luarocks spec

1 participant