Ignore copyright symbols inside URLs during copyright detection#4744
Open
dikshaa2909 wants to merge 4 commits intoaboutcode-org:developfrom
Open
Ignore copyright symbols inside URLs during copyright detection#4744dikshaa2909 wants to merge 4 commits intoaboutcode-org:developfrom
dikshaa2909 wants to merge 4 commits intoaboutcode-org:developfrom
Conversation
12b4a11 to
8f51b45
Compare
Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
Refactor copyright symbol detection to ignore (c) only in URL paths. Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
Add test for copyright detection with URL Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4724
Summary
This PR fixes a false-positive issue where ScanCode detects copyright statements when a copyright symbol
(c)appears inside a URL.URLs such as:
http://example.com/(c)/path
were incorrectly treated as copyright candidates, even though they are not copyright statements.
Problem
ScanCode’s copyright candidate detection logic treated
(c)inside URLs as a valid copyright marker.This resulted in incorrect detections when scanning text files containing URLs with
(c)in the path.Solution
Tests
test_copyright_symbol_inside_url_is_ignoredTasks
(Tests also run locally)
Signed of by dikshadeware@gmail.com