Upgrade XGBoost to v3.0.5 and modernize build#47
Open
cdmwebs wants to merge 16 commits intoacalejos:mainfrom
Open
Upgrade XGBoost to v3.0.5 and modernize build#47cdmwebs wants to merge 16 commits intoacalejos:mainfrom
cdmwebs wants to merge 16 commits intoacalejos:mainfrom
Conversation
- Drop Intel Mac support
Owner
|
@cdmwebs Thanks so much for this PR! I'll try to take a look this weekend |
|
This is fantastic! Thank you so much for your effort in keeping this library up to date 🙏 |
Author
|
We use it everyday. Happy to help. |
|
@acalejos do you think this is good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core of the update is a major version upgrade of the underlying XGBoost C++ dependency, along with significant modernization of the build system and fixes for API compatibility.
Problem
The library was pinned to an older v2-era version of XGBoost. This resulted in build failures on up-to-date toolchains, including:
Solution
This PR addresses these issues with the following key changes:
The library now compiles cleanly and passes its entire test suite on a modern Erlang (28) and Elixir (1.18) development environment.
Precompiled Binaries (GH workflows)