Skip to content

Comments

feat(user): add getAccountDevices function to retrieve user devices#208

Merged
wescopeland merged 7 commits intoachievements-app:mainfrom
Dev-R:main
Jul 13, 2025
Merged

feat(user): add getAccountDevices function to retrieve user devices#208
wescopeland merged 7 commits intoachievements-app:mainfrom
Dev-R:main

Conversation

@Dev-R
Copy link
Contributor

@Dev-R Dev-R commented Jun 30, 2025

This PR resolves #207.

@vercel
Copy link

vercel bot commented Jun 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
psn-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2025 8:38pm

@Dev-R
Copy link
Contributor Author

Dev-R commented Jun 30, 2025

Hello @wescopeland ,

This PR could be a good opportunity to add a client directory to the project. Since this method will only work for the authenticated user, it does not accept onlineId or accountId, and is limited to the client. Putting it under the users doesn't make much sense.

Let me know what you think!

@wescopeland
Copy link
Member

Hey @Dev-R 👋

Apologies for my delayed response, I have been swamped this week. Happy to give this a review tomorrow :) Looks like there may be one check that's failing.

@wescopeland
Copy link
Member

Hey @Dev-R 👋 Happy to review this once checks are passing.

@Dev-R
Copy link
Contributor Author

Dev-R commented Jul 3, 2025

@wescopeland All checks passed!

@wescopeland
Copy link
Member

Thank you @Dev-R! We have a few commands in package.json that can make this easier for future PRs:

pnpm format:write
pnpm lint:fix

These should clear up any autofixable issues that may be present.

I'll get a review in for the PR shortly.

Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wescopeland wescopeland merged commit 61ee707 into achievements-app:main Jul 13, 2025
7 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sync] Port get_account_devices() from psnawp

2 participants