Skip to content

Merge all#24

Open
Frozenlock wants to merge 5 commits intoachin:masterfrom
Frozenlock:merge-all
Open

Merge all#24
Frozenlock wants to merge 5 commits intoachin:masterfrom
Frozenlock:merge-all

Conversation

@Frozenlock
Copy link

Add the ability to merge ALL properties (except the name) from a parent project without having to manually update the inherit field in all the children.

How to use:

Add leiningen.parent/all as an inherit keyword.

  :parent-project {:coords  ...
                   :inherit [:leiningen.parent/all]} ; <---

@achin
Copy link
Owner

achin commented Jun 21, 2020

Thanks for your contribution. I'll merge your PRs and release a new version as soon as I can.

Do you think there's a chance that you may have forgotten to check in a new with_parent_inherit_all sample/test project? I'm getting the following errors running lein test.

lein test

lein test leiningen.t-parent

lein test :only leiningen.t-parent/inherited-values-test

ERROR in (inherited-values-test) (project.clj:1046)
Uncaught exception, not in assertion.
expected: nil
  actual: java.lang.Exception: Error loading ./dev-resources/t_parent/samples/children/with_parent_inherit_all/project.clj
 at leiningen.core.project$read_raw$fn__7295.invoke (project.clj:1046)
    leiningen.core.project$read_raw.invokeStatic (project.clj:1040)
    leiningen.core.project$read_raw.invoke (project.clj:1036)
    leiningen.core.project$read.invokeStatic (project.clj:1057)
    leiningen.core.project$read.invoke (project.clj:1054)
    leiningen.core.project$read.invokeStatic (project.clj:1058)
    leiningen.core.project$read.invoke (project.clj:1054)
...
Ran 2 tests containing 10 assertions.
0 failures, 1 errors.
Tests failed.

@Frozenlock
Copy link
Author

You are right, I have some new unchecked files. I'll fix this ASAP.

@Frozenlock
Copy link
Author

I have another PR I'm working on, so you might want to wait a little before a new release.

@achin
Copy link
Owner

achin commented Jun 21, 2020 via email

@Frozenlock Frozenlock mentioned this pull request Jun 22, 2020
@Frozenlock
Copy link
Author

My next PR might be more involved with a higher risk of conflict if the pending PRs are not accepted or require revisions.

When you'll have time, could you give a look at the pending PRs and merge them (without releasing a new version yet)?

@achin
Copy link
Owner

achin commented Jun 22, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants