-
Notifications
You must be signed in to change notification settings - Fork 74
Automate removing expired servers #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This looks great @jkisor. Looking at the current list, we have some servers that are often down like GDLE Test and Hightide. We might first discuss whether to keep these listed types of servers in the list and, if so, then discuss tweaking this action's logic to ignore one or more servers. I'm going to leave this unmerged until discussion wraps up in #111. Thanks again. |
|
I've returned to refactor and add a keep list. There's a new file, "keep", for adding server IDs to exclude. I've gone ahead and added the example servers you shared. But ... I discovered that I misunderstood the values returned by |
|
My fault there, sorry @jkisor. I've since pushed an update that should report this correctly. For servers that have been seen, you get: "status": {
"online": true,
"last_seen": "2023-02-06T03:13:57Z",
"last_checked": "2023-02-06T03:13:56Z"
}Note: last_seen will be |
|
I'm still interested in seeing this added but need to do some refactoring of https://servers.treestats.net to support this and I'm just really busy at the moment. I'll revisit this when the service is in a good state and work on getting this merged. |
|
I refactored some things on https://servers.treestats.net and it's ready for use here. I pushed some minor tweaks to jkisor#4 so please have a look and merge those so this PR updates. I think we could merge this and still discuss (1) how long it takes us to consider a server expired and (2) what we do when we expire a server. In #110, @Mag-nus points out we could flip a flag instead of removing a server from the list and ask tools (i.e. ThwargLauncher) to respect it. |
Requirements:
How it's triggered:
How it works:
https://servers.treestats.net. For more info on how this data source works, go hereServers.xmland opens a pull request