Span Buffer Multiprocess Enhancement with Health Monitoring#5
Open
adamsaimi wants to merge 1 commit intospan-flusher-stablefrom
Open
Span Buffer Multiprocess Enhancement with Health Monitoring#5adamsaimi wants to merge 1 commit intospan-flusher-stablefrom
adamsaimi wants to merge 1 commit intospan-flusher-stablefrom
Conversation
adamsaimi
commented
Oct 25, 2025
| self.process_healthy_since[process_index].value = int(time.time()) | ||
|
|
||
| # Create a buffer for these specific shards | ||
| shard_buffer = SpansBuffer(shards) |
Owner
Author
There was a problem hiding this comment.
[Performance] Excessive Redis Connections per Flusher Process
- Problem: Each
SpanFlusherprocess creates an independent Redis connection pool, potentially leading to an excessive number of connections and Redis overload whenflusher_processesis high. - Fix: Implement a mechanism to limit total Redis connections across flusher processes or provide clear operational guidance on configuring
flusher_processesrelative to Redis capacity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test 6