GitHub OAuth Security Enhancement#7
Open
adamsaimi wants to merge 1 commit intooauth-state-vulnerablefrom
Open
Conversation
…#67876) We're adding one more step in the GitHub integration installation pipeline, namely GitHub OAuth2 authorize. This is transparent from the UX perspective as the data exchange happens without user interaction. The pipeline will now fail in these cases: - If there is a mismatch between currently authenticated GitHub user (derived from OAuth2 authorize step) and the user who installed the GitHub app (https://github.com/apps/sentry-io) - If there is a mismatch between `state` parameter supplied by user and pipeline signature - If GitHub could not generate correct `access_token` from the `code` (wrong or attempt of re-use of `code`). In all those cases, this error is shown: 
adamsaimi
commented
Oct 25, 2025
| } | ||
|
|
||
| # similar to OAuth2CallbackView.exchange_token | ||
| req = safe_urlopen(url=ghip.get_oauth_access_token_url(), data=data) |
Owner
Author
There was a problem hiding this comment.
[Refactor] Overloaded OAuthLoginView
- Problem: The
OAuthLoginViewmixes pipeline orchestration with low-level OAuth protocol details and direct HTTP requests, violating separation of concerns. - Fix: Refactor the view to delegate low-level OAuth protocol details and HTTP requests to a dedicated service or helper, making the view more focused and testable.
adamsaimi
commented
Oct 25, 2025
|
|
||
| installation_id = request.GET.get("installation_id") | ||
| if installation_id: | ||
| pipeline.bind_state("installation_id", installation_id) |
Owner
Author
There was a problem hiding this comment.
[Security] Missing installation_id Validation
- Problem: The
installation_idis used directly fromrequest.GETwithout immediate explicit validation, potentially allowing misuse before later database lookups. - Fix: Implement a basic type or format validation for
installation_idimmediately after retrieving it fromrequest.GET.
adamsaimi
commented
Oct 25, 2025
| # redirect to the integration install org picker. | ||
| if ( | ||
| provider_id in FORWARD_INSTALL_FOR | ||
| provider_id == "github" |
Owner
Author
There was a problem hiding this comment.
[Refactor] Reduced Pipeline Advancer Extensibility
- Problem: The
pipeline_advancerlogic is hardcoded forprovider_id == "github", limiting its extensibility for other providers. - Fix: Restore a generic mechanism, such as the
FORWARD_INSTALL_FORlist, to allow easier configuration for future providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test 4