feat: upgrade to AdCP protocol 2.6.0 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update ADCP_VERSION to 2.6.0 - Sync schemas from upstream adcontextprotocol.org - Regenerate Python types from new schemas - Fix sync_schemas.py to look for ADCP_VERSION in correct location (src/adcp/) - Fix Makefile to use generate_types.py instead of missing generate_models_simple.py
BaiyuScope3
changed the title
- Remove inline comments that broke import block sorting - Fix generate_ergonomic_coercion.py to not emit comments in import block
Change format_ back to format in the FieldModel enum since enum members are accessed via EnumName.member and don't conflict with Python builtins. The enum value remains 'format' for correct JSON serialization.
BaiyuScope3
force-pushed
the
adcp_2_6_support
branch
from
29d2c75 to
1a6ab9a
Compare
…required migration - Add format_assets.py with utilities for backward-compatible asset access: - get_format_assets(): prefers new 'assets' field, falls back to assets_required - normalize_assets_required(): converts deprecated format with required=True - get_required_assets() / get_optional_assets(): filter by required status - get_individual_assets() / get_repeatable_groups(): filter by item type - uses_deprecated_assets_field(): check if using deprecated field - get_asset_count() / has_assets(): utility helpers - Add generic deprecation warning in CLI for any field with deprecated=True - Update _create_sample_manifest_for_format() to use new utilities - Export all utilities from adcp package - Add comprehensive tests for new utilities (19 tests) - Add new tests for assets field while keeping assets_required tests for backward compat No breaking changes - all changes are backward compatible.
BaiyuScope3
commented
Jan 8, 2026
BaiyuScope3
commented
Jan 8, 2026
BaiyuScope3
commented
Jan 8, 2026
BaiyuScope3
commented
Jan 8, 2026
BaiyuScope3
commented
Jan 8, 2026
- Add add_deprecated_field_metadata() to post_generate_fixes.py - Reads JSON schemas to find fields with deprecated: true - Injects Field(deprecated=True) into generated Python files - Fix Pydantic v2.11 deprecation warnings in CLI - Access model_fields from class instead of instance - Suppress DeprecationWarning when checking deprecated field values - Add tests for CLI deprecation warning functionality - Add test for normalize_assets_required with repeatable groups - Simplify _is_required and _get_item_type helpers Coverage: 80.47%
bokelley
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to AdCP Protocol 2.6
Summary
Updates schema definitions and adds utilities to support the AdCP 2.6 protocol, including the migration from assets_required to the new assets field.
Changes
Schema Updates (from upstream)
New Format Asset Utilities
Deprecation Warnings
Bugfix
Tests
Cli warnings
Breaking Changes
None. All changes should be backward compatible.