Skip to content

Criticall: convert leading spaces to tabs#1

Merged
adil-adysh merged 15 commits intoadil-adysh:mainfrom
josephsl:spaces2tabs
Feb 17, 2026
Merged

Criticall: convert leading spaces to tabs#1
adil-adysh merged 15 commits intoadil-adysh:mainfrom
josephsl:spaces2tabs

Conversation

@josephsl
Copy link

@josephsl josephsl commented Feb 6, 2026

Hi,

This pull request converts leading spaces to tas throughout the ad-don source code. This is a critical change to make the add-on code comply with NVDA coding style.

Thanks.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request converts leading spaces to tabs throughout the NVDA add-on source code to comply with NVDA coding style conventions. Beyond the primary formatting changes, the PR also introduces modern development tooling including Ruff for linting/formatting, Poetry for dependency management, pre-commit hooks, and GitHub Actions for automated code quality checks.

Changes:

  • Converted all leading spaces to tabs across Python files to match NVDA coding standards
  • Added Ruff configuration, Poetry dependency management, pre-commit hooks, and CI/CD workflow for code quality enforcement
  • Improved code quality by removing unused imports, fixing bare except clauses, correcting operator spacing, and simplifying boolean comparisons

Reviewed changes

Copilot reviewed 20 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Added project metadata, Poetry configuration, and Ruff linting/formatting settings with tab indentation
poetry.lock Added Poetry lock file with Ruff 0.5.7 dependency
.pre-commit-config.yaml Added pre-commit hooks for ruff-format and ruff linting with auto-fix
.github/workflows/code-quality.yml Added CI/CD workflow for automated format checking and linting
site_scons/site_tools/NVDATool/*.py Converted indentation to tabs, fixed operator spacing in type hints
sconstruct Converted indentation to tabs, fixed quote consistency
buildVars.py Converted indentation to tabs, improved multiline string formatting
download_pandoc.py Converted indentation to tabs, improved exception handling (bare except → except Exception)
addon/installTasks.py Converted indentation to tabs, improved exception handling and multiline formatting
addon/globalPlugins/quickNotetaker/*.py Converted indentation to tabs, removed unused imports (gui, re, sys, log, DpiScalingHelperMixin), improved boolean comparisons (== True → truthiness), fixed spacing around operators
.vscode/typings/builtins.pyi Simplified function signatures to single-line format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adil-adysh adil-adysh merged commit adfefd4 into adil-adysh:main Feb 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants