Criticall: convert leading spaces to tabs#1
Merged
adil-adysh merged 15 commits intoadil-adysh:mainfrom Feb 17, 2026
Merged
Conversation
…th ruff and GitHub Actions
…gement and ruff commands
… up and dependencies are installed
There was a problem hiding this comment.
Pull request overview
This pull request converts leading spaces to tabs throughout the NVDA add-on source code to comply with NVDA coding style conventions. Beyond the primary formatting changes, the PR also introduces modern development tooling including Ruff for linting/formatting, Poetry for dependency management, pre-commit hooks, and GitHub Actions for automated code quality checks.
Changes:
- Converted all leading spaces to tabs across Python files to match NVDA coding standards
- Added Ruff configuration, Poetry dependency management, pre-commit hooks, and CI/CD workflow for code quality enforcement
- Improved code quality by removing unused imports, fixing bare except clauses, correcting operator spacing, and simplifying boolean comparisons
Reviewed changes
Copilot reviewed 20 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added project metadata, Poetry configuration, and Ruff linting/formatting settings with tab indentation |
| poetry.lock | Added Poetry lock file with Ruff 0.5.7 dependency |
| .pre-commit-config.yaml | Added pre-commit hooks for ruff-format and ruff linting with auto-fix |
| .github/workflows/code-quality.yml | Added CI/CD workflow for automated format checking and linting |
| site_scons/site_tools/NVDATool/*.py | Converted indentation to tabs, fixed operator spacing in type hints |
| sconstruct | Converted indentation to tabs, fixed quote consistency |
| buildVars.py | Converted indentation to tabs, improved multiline string formatting |
| download_pandoc.py | Converted indentation to tabs, improved exception handling (bare except → except Exception) |
| addon/installTasks.py | Converted indentation to tabs, improved exception handling and multiline formatting |
| addon/globalPlugins/quickNotetaker/*.py | Converted indentation to tabs, removed unused imports (gui, re, sys, log, DpiScalingHelperMixin), improved boolean comparisons (== True → truthiness), fixed spacing around operators |
| .vscode/typings/builtins.pyi | Simplified function signatures to single-line format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request converts leading spaces to tas throughout the ad-don source code. This is a critical change to make the add-on code comply with NVDA coding style.
Thanks.