fix: generateKeyPair for non node environments#4
Open
samuelscheit wants to merge 1 commit intoadiwajshing:masterfrom
Open
fix: generateKeyPair for non node environments#4samuelscheit wants to merge 1 commit intoadiwajshing:masterfrom
samuelscheit wants to merge 1 commit intoadiwajshing:masterfrom
Conversation
mendoza0018
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node's generateKeyPairSync function generates a public key of length 44, which then gets sliced down to 33 bytes with the first byte of the sliced down key being the number
5.However the CurveJs generateKeyPair function generates a public key of length 32.
I added the number 5 as a prefix to the CurveJs public key to be consistent with the node function.