Add isset check on $entries[$i]["description"]#53
Open
julianbolts wants to merge 2 commits intoadldap:masterfrom
Open
Add isset check on $entries[$i]["description"]#53julianbolts wants to merge 2 commits intoadldap:masterfrom
julianbolts wants to merge 2 commits intoadldap:masterfrom
Conversation
Contributor
|
Would if ($includeDescription && !empty($entries[$i]["description"][0])) {
...
} |
Author
|
Yes, that worked just fine in my implementation. Thanks for the suggestion. Do I need to resubmit the pull request? (Sorry-this is my first one) |
Contributor
Nope, anything you push to that branch will be part of the PR. :-) |
Contributor
|
Can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using your library (it's a great tool BTW) and came across this exception while using the $adLDAP->groups()->all() method.
exception 'ErrorException' with message 'Undefined index: description'
To fix this error, I added a conditional to the if clause that was searching for data in $entries[$i]["description"]. I figured I might pass this on in case it is helpful to others.