-
Notifications
You must be signed in to change notification settings - Fork 52
IMPROVEMENT: Added meta.queueTimeMillis to network request to record time between event creation and sent #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Spencer-Smith
wants to merge
9
commits into
main
Choose a base branch
from
impr/noStampOnlyQueue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterworks
reviewed
Dec 16, 2025
jonsnyder
reviewed
Dec 16, 2025
packages/core/test/integration/specs/Command Logic/queueTimeMillis.spec.js
Show resolved
Hide resolved
…hen request is sent
jonsnyder
approved these changes
Jan 7, 2026
Contributor
jonsnyder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Be sure to manually test it with an assurance session to make sure the queuedTimeMillis is applied to the event when xdm.timestamp is deleted.
carterworks
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes event timestamp during event finalization and adds a
metaproperty to determine the amount of time the event was enqueued.Related Issue
Jira
Motivation and Context
Timestamps from the WebSDK are dependent on user device settings and so can be inaccurate. In order to avoid TIME DRIFT in Konductor, we should no longer send event timestamps in the SDK. Instead, Konductor will insert the timestamp when the request is received. Because send event commands can be queued (while they wait for script load, consent, identity, etc.), we need to track the delta between when the command is enqueued and when it is actually sent to determine in Konductor when the event occurred.
Screenshots (if appropriate):
N/A
Checklist: