-
Notifications
You must be signed in to change notification settings - Fork 357
#2060 Add fieldgroups and examples supporting Paid Media #2063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
#2060 Add fieldgroups and examples supporting Paid Media #2063
Conversation
68ecc4b to
61b5721
Compare
bf25923 to
fe7439a
Compare
596fa8e to
a63f4c5
Compare
| { | ||
| "xdm:fieldName": "custom_score", | ||
| "xdm:numberValue": { | ||
| "xdm:value": 87.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as on previous PR; do you need the id field that comes with the https://ns.adobe.com/xdm/data/measure datatype?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in previous PR
| "title": "Website URL", | ||
| "description": "Business website URL" | ||
| }, | ||
| "xdm:address": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using "Postal Address" standard data type https://ns.adobe.com/xdm/common/address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it
| "type": "object", | ||
| "meta:extensible": true, | ||
| "meta:abstract": true, | ||
| "meta:intendedToExtend": ["https://ns.adobe.com/xdm/data/record"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta:intendedToExtend must specify class(es) and not a behavior. https://ns.adobe.com/xdm/data/record is a behavior.
Please make this change to the rest of the field groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create paid-media class
e334f47 to
3fbb1bc
Compare
3fbb1bc to
d76ae4f
Compare
Issue #2060 will involve multiple PRs to keep the review effort manageable.
This stacked PR should not be merged before PR #2061 and should be rebased after that one is merged.
This PR adds the fieldgroups that build upon the datatypes added in #2061. These new fieldgroups capture Paid Media domain heirarchy knowledge across ad networks (meta, linkedIn, google ads, etc) such as:
It also captures performance metrics concepts, which can be reused at the various hierarchy levels mentioned above. For example, clicks/impressions performance metrics might apply at the Asset level, Ad level, Ad Group level, or Campaign level.
This PR also adds a validation script ("npm run validate") to ensure example files actually adhere to their associated schemas, and that schema "$id" references to other remote schemas actually refer to either: