Fix encoding of PARAMS arguments in FT.SEARCH #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSapin
commented
May 6, 2025
Comment on lines
+322
to
323
| // TODO: times 2 for the number of arguments, no the number of pairs | ||
| args.push(options.params.len().try_into()?); |
Author
There was a problem hiding this comment.
I don’t have an environment to easily run the test suite so I was hoping for this first commit without the fix to witness a failing CI run, but it looks like CI is not enabled on PRs from forks. The fix below works for me:
Suggested change
| // TODO: times 2 for the number of arguments, no the number of pairs | |
| args.push(options.params.len().try_into()?); | |
| args.push((options.params.len() * 2).try_into()?); |
SimonSapin
added a commit
to SimonSapin/fred.rs
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346