Introduce a dialogue defintion layer for future dialogue work#313
Open
rapidsamphire wants to merge 1 commit intoafritz1:mainfrom
Open
Introduce a dialogue defintion layer for future dialogue work#313rapidsamphire wants to merge 1 commit intoafritz1:mainfrom
rapidsamphire wants to merge 1 commit intoafritz1:mainfrom
Conversation
…nums plus a comprehensive DialogueVariableType list, attribute flags, and lookup API so future
systems can reason about every %token documented in the Arena reference (OpenTESArena/src/Interface/DialogueDefinition.h:1-156).
- Implemented the backing metadata table in DialogueDefinition.cpp, capturing each token’s description, whether it randomizes, normalizes whitespace, or sets speaker
gender, and exposed helpers to iterate or resolve variables by token/enum (OpenTESArena/src/Interface/DialogueDefinition.cpp:1-135).
- Registered the new dialogue definitions in the Interface target so they build with the rest of the game code (OpenTESArena/CMakeLists.txt:208-360).
Owner
|
Okay, this seems fine at a glance. I may wait on this until the UI refactor is done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build compiles correctly.