Conversation
HyunggyuJang
requested review from
Grazfather,
agzam and
jaidetree
as code owners
|
Originated from #159 (comment). |
Grazfather
left a comment
Grazfather
left a comment
There was a problem hiding this comment.
Good start, I won't be able to play with this for about a week, though.
| @@ -0,0 +1,20 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
what do you need internal.so stuff for/how did it get in here? We obviously cannot add dynamic libraries directly to this repo, ignoring that it's arch specific, it's also a security nightmare :)
| " | ||
| Swap window using hhtwm. | ||
| " | ||
| (let [dir {:h "west" :j "south" :k "north" :l "east"} |
There was a problem hiding this comment.
Why encode the hjkl part here? e.g. Why not just have swap-window-left call swap-window :left?
There was a problem hiding this comment.
I mean swap-window :west. You're adding an intermediate hjkl to compass mapping, when you could encode a 'left right up down' to compass mapping directly in the function calls.
| - Set layout as the main window comes to the right half of current display | ||
| - Start tiling | ||
| " | ||
| (hhtwm.setLayout "main-right") |
There was a problem hiding this comment.
We probably want the default somewhere in the config so that users can easily change this.
|
Thanks for your review @Grazfather, unfortunately, for a month from now, I need to write my thesis, so can’t look into and reflect commented points. I’ll come back about middle of February! |
|
No real rush, thanks for pushing the PR so that I can play with it. Good luck on your thesis! |
|
Your kind words warmed my heart! Thanks. |
|
How is your thesis going? Are you still interested in picking up this work? |
Sorry for the super late update. Yes, successfully completed my thesis! Thanks a lot for your interest. I haven’t used hhtwm since then, so let me check it whether it is still feasible and worth to integrate it. |
|
Congratulations! And no worries, we can get this PR working again or just ditch it, although I am interested to try it out. |
2 participants
This is an attempt to merge HHTWM's tiling feature into spacehammer's realm.