Skip to content

fix: Uses auto_merge param #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaacsanders wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Uses auto_merge param #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a2a1f8
fix: Uses auto_merge param
isaacsanders Aug 11, 2022
7e6fc8a
fix: Adds unreachable return for type consistency
isaacsanders Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ func (p *OutParams) UnmarshalJSON(b []byte) (err error) {
p.Description = github.String(getStringOrStringFromFile(p.RawDescription))
}

if p.RawAutoMerge != nil {
p.AutoMerge = github.Bool(getBool(p.RawAutoMerge))
}

var payload map[string]interface{}
json.Unmarshal(p.RawPayload, &payload)

Expand Down Expand Up @@ -140,6 +144,19 @@ func NewOutRequest() OutRequest {
return OutRequest{}
}

func getBool(field json.RawMessage) bool {
var rawValue interface{}
if err := json.Unmarshal(field, &rawValue); err == nil {
switch rawValue := rawValue.(type) {
case bool:
return rawValue
default:
panic("Could not read bool out of Params field")
}
}
return true
}

func getStringOrStringFromFile(field json.RawMessage) string {
var rawValue interface{}
if err := json.Unmarshal(field, &rawValue); err == nil {
Expand Down