Reduce index path lookups #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
commented
Dec 3, 2025
| case .topItem(let id, let _elementLocation, let distanceFromTop): | ||
| let elementLocation = | ||
| if isPerformingBatchUpdates { | ||
| modelState.indexPathForItemModel(withID: id).map(ElementLocation.init(indexPath:)) |
Contributor
Author
There was a problem hiding this comment.
this is the O(n) call we can avoid as long as we're not performing batch updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR reduces calls to
modelState.indexPathForItem(withID:)when calculating theyOffsetfor atargetContentOffsetAnchor. In most cases, like when scrolling and self-sizing cells, we already know the index path of thetargetContentOffsetAnchoritem - it's only when performing batch updates that we need to look up an index path using an ID (anO(n)search), since the index path might have changes as a result of batch updates.Motivation and Context
Perf