Remove test cases that are no longer valid with go 1.17 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Actually, perhaps I should just change the ';' characters to '&' which is still a valid separator. Do the devs here have an opinion? |
Author
I went with this as it's a much smaller change that doesn't remove any test coverage. |
|
@jawn-smith could you explain this in brief? I know very little about Golang to be honest, and I am trying to package an application, which is indirectly dependent on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of go 1.17, the net/http and net/url packages no longer accept ';' as a valid separator. See https://golang.org/doc/go1.17#semicolons for more information.
In order to build this package with go 1.17 and keep it in Ubuntu, the test cases that use ';' as a separator should be removed.