Feature/first use case by akisma · Pull Request #4 · akisma/mastertour-mcp

akisma · 2026-01-04T23:45:08Z

adds all that we can actually accomplish for a reasonable TM use case. includes refactors and cleanups as we move into semi-functional mode. also adds basic CI to run tests with each PR.

Add CI workflow for PR/push, create tsconfig.test.json with allowImportingTsExtensions, fix mock data types, add VS Code settings

…ta + text Add typed output interfaces, update 127 tests, update all docs, add GitHub Actions CI

src/utils/formatters.ts

Copilot

Pull request overview

This PR implements Phase 4 of the Mastertour MCP server, adding venue research capabilities and completing a major architecture refactoring. The PR adds 3 new venue-focused tools, introduces structured output types across all 12 tools, implements dependency injection for better testability, and establishes CI/CD with GitHub Actions.

Key Changes:

Added venue research tools: search_past_venues, get_venue_details, get_upcoming_shows
Refactored to use dependency injection pattern with singleton client instance
Introduced structured ToolResult<T> return type for all tools providing both typed data and human-readable text
Created shared utilities: formatters module and tour iterator for code reuse
Established GitHub Actions CI workflow with Node 20.x/22.x matrix testing

Reviewed changes

Copilot reviewed 44 out of 45 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`src/config.ts`	New configuration module with fail-fast validation for environment variables
`src/auth/oauth.ts`	Refactored OAuth client to support explicit credential injection
`src/index.ts`	Refactored server initialization to use dependency injection pattern
`src/types/outputs.ts`	New structured output type definitions for all tool return values
`src/utils/formatters.ts`	Shared formatting utilities (dates, fields, contacts, search normalization)
`src/utils/tourIterator.ts`	Async generator for iterating tours/days with filtering
`src/tools/searchPastVenues.ts`	New tool for searching venues from historical tours
`src/tools/getVenueDetails.ts`	New tool for retrieving complete venue information
`src/tools/getUpcomingShows.ts`	New tool for listing upcoming shows across tours
`src/tools/*.ts` (updates)	All existing tools updated to return `ToolResult<T>` structured outputs
`src/api/client.ts`	Added `getTourAll` and `getDayEvents` methods for venue research
`tests/*/.test.ts`	Updated imports from `.js` to `.ts`, assertions changed to use `result.text`
`.github/workflows/ci.yml`	New GitHub Actions CI workflow
`vitest.config.ts`	Added typecheck configuration
`tsconfig.test.json`	New TypeScript config for test files
`docs/*.md`	Updated documentation reflecting Phase 4 completion and architecture changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-04T23:48:48Z

tests/unit/searchPastVenues.test.ts

+    },
+  };
+
+  const mockDayEvents: Record<string, any[]> = {


Using any[] for the type defeats TypeScript's type safety. Consider using a more specific type like DayEvent[] or creating a proper mock type.

Copilot · 2026-01-04T23:48:48Z

src/tools/getVenueDetails.ts

+  const contacts: VenueContactOutput[] = extractContacts(venueEvent.venueContacts);
+
+  const data: VenueDetailsOutput = {
+    dayId: venueId, // Using venueId as identifier


Same issue as in searchPastVenues: the dayId field is being assigned venueId instead of an actual day ID. This creates confusion about what the field represents. Consider renaming to venueId in the output type or storing the actual day ID.

Suggested change

dayId: venueId, // Using venueId as identifier

dayId: venueEvent.dayId,

Copilot · 2026-01-04T23:48:48Z

src/utils/tourIterator.ts

+ * reducing code duplication in venue research tools.
+ */
+
+import type { MasterTourClient, TourInfo, EventDayInfo, DayEvent, TourAllResponse } from '../api/client.js';


The import uses .js extension for TypeScript files, but this might be inconsistent with other imports in the codebase. Consider whether imports should consistently use .ts extensions for TypeScript source files, especially given that test files have been updated to use .ts extensions.

Suggested change

import type { MasterTourClient, TourInfo, EventDayInfo, DayEvent, TourAllResponse } from '../api/client.js';

import type { MasterTourClient, TourInfo, EventDayInfo, DayEvent, TourAllResponse } from '../api/client.ts';

Copilot · 2026-01-04T23:48:49Z

src/tools/searchPastVenues.ts

+
+  // Build structured data
+  const outputResults: VenueSearchResultOutput[] = results.map((v) => ({
+    dayId: v.venueId, // Using venueId as dayId since we don't track specific days


The dayId field is being misused here - it's assigned the venueId instead of an actual day ID. This creates a misleading API where the field name doesn't match the data. Consider either renaming the field in VenueSearchResultOutput to venueId, or storing the actual day ID where this venue was found.

Suggested change

dayId: v.venueId, // Using venueId as dayId since we don't track specific days

dayId: '', // No specific day ID is tracked for these aggregated venue results

Copilot · 2026-01-04T23:48:49Z

tests/unit/getTodaySchedule.test.ts

      expect(mockClient.getTourSummary).toHaveBeenCalledWith('tour123', today);
    });
-  });
+  });;


There's a double semicolon at the end of this line. Remove one semicolon.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-01-04T23:48:49Z

.github/workflows/ci.yml

+          MASTERTOUR_CONSUMER_KEY: test-key
+          MASTERTOUR_CONSUMER_SECRET: test-secret
+          MASTERTOUR_ACCESS_TOKEN: test-token
+          MASTERTOUR_TOKEN_SECRET: test-secret


The environment variables in the CI workflow don't match the actual configuration used by the application. The code uses MASTERTOUR_KEY and MASTERTOUR_SECRET (from config.ts), but the CI workflow sets MASTERTOUR_CONSUMER_KEY, MASTERTOUR_CONSUMER_SECRET, MASTERTOUR_ACCESS_TOKEN, and MASTERTOUR_TOKEN_SECRET. This mismatch will cause CI tests to fail if they rely on environment configuration.

Suggested change

MASTERTOUR_CONSUMER_KEY: test-key

MASTERTOUR_CONSUMER_SECRET: test-secret

MASTERTOUR_ACCESS_TOKEN: test-token

MASTERTOUR_TOKEN_SECRET: test-secret

MASTERTOUR_KEY: test-key

MASTERTOUR_SECRET: test-secret

Copilot · 2026-01-05T00:22:02Z

@akisma I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you.

[WIP] Update to address feedback on Feature/first use case PR

jess-ve added 3 commits January 4, 2026 14:30

add getVenueDetails, SearchPastVenues, getUpcomingShows

4c0e9de

Add GitHub Actions CI and fix TypeScript test configuration

8694588

Add CI workflow for PR/push, create tsconfig.test.json with allowImportingTsExtensions, fix mock data types, add VS Code settings

refactor: structured outputs - all tools return ToolResult<T> with da…

4b2a910

…ta + text Add typed output interfaces, update 127 tests, update all docs, add GitHub Actions CI

akisma requested a review from Copilot January 4, 2026 23:45

Copilot started reviewing on behalf of akisma January 4, 2026 23:45 View session

github-advanced-security bot found potential problems Jan 4, 2026

View reviewed changes

src/utils/formatters.ts Fixed Show fixed Hide fixed

Copilot AI reviewed Jan 4, 2026

View reviewed changes

jess-ve and others added 3 commits January 4, 2026 15:54

fix lint

8d83913

fix escaping order

f51acf9

Initial plan

f821cb0

Copilot AI mentioned this pull request Jan 5, 2026

[WIP] Update to address feedback on Feature/first use case PR #5

Merged

5 tasks

Merge pull request #5 from akisma/copilot/sub-pr-4

6465cab

[WIP] Update to address feedback on Feature/first use case PR

akisma merged commit d3d55b5 into main Jan 5, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Feature/first use case#4

Feature/first use case#4
akisma merged 7 commits intomainfrom
feature/first-use-case

akisma commented Jan 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

akisma Jan 5, 2026

Uh oh!

Copilot AI Jan 4, 2026

Uh oh!

Copilot AI commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	dayId: venueId, // Using venueId as identifier
	dayId: venueEvent.dayId,

	import type { MasterTourClient, TourInfo, EventDayInfo, DayEvent, TourAllResponse } from '../api/client.js';
	import type { MasterTourClient, TourInfo, EventDayInfo, DayEvent, TourAllResponse } from '../api/client.ts';

	dayId: v.venueId, // Using venueId as dayId since we don't track specific days
	dayId: '', // No specific day ID is tracked for these aggregated venue results

Comments

Conversation

akisma commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

akisma Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akisma commented Jan 4, 2026 •

edited

Loading