Fixed a bug for "My Games" view with no games.#122
Fixed a bug for "My Games" view with no games.#122ernestasromeika wants to merge 124 commits intoale64bit:mainfrom
Conversation
This reverts commit 029712a.
…i.e. a new account)
ale64bit
left a comment
There was a problem hiding this comment.
Thanks for the fix! The translated terms for Spanish and Russian sound odd (in Spanish it should be "partida" and in Russian "партия" to be consistent with the rest of the interface).
Maybe it's easier instead to make prototypeItem optional and thus avoid additional localization? e.g.
(...)
final first = items.firstOrNull;
return ListView.builder(
itemCount: items.length,
prototypeItem: first == null ? null : _GameListTile(
summary: first,
(...)|
Circling back to this. I think having a message is nice, otherwise it's just a black screen (with some buttons). I used google translate for those values so that's why they don't sound very native.. (as I don't speak them). I'm down to update the translation values or remove it, your call. Will fix the conflict once we decide what to do |
Yes, I agree that a message is better. |
cae9122 to
3009a61
Compare
Fixed a view crash when navigating to "My Games", when no games exist (i.e. on a new account).