add black to play behavior to task_preview_tile#196
Open
Cidragon wants to merge 225 commits intoale64bit:mainfrom
Open
add black to play behavior to task_preview_tile#196Cidragon wants to merge 225 commits intoale64bit:mainfrom
Cidragon wants to merge 225 commits intoale64bit:mainfrom
Conversation
This reverts commit b968107.
ale64bit
reviewed
Feb 6, 2026
| ); | ||
| } | ||
|
|
||
| final task = context.settings.alwaysBlackToPlay == true && |
Owner
There was a problem hiding this comment.
can't we simplify this condition?
final task = context.settings.alwaysBlackToPlay
? taskData.withBlackToPlay()
: taskData;
Contributor
Author
There was a problem hiding this comment.
yes, the function withBlackToPlay does check if the first to move is black to play so it's not necessary to check it previously.
I can remove the second condition if you want, the only problem is that i don't know what should I do now that the pull request doesn't follow the main branch anymore. do I need to sync first and then commit later?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #195
The code only does 2 simple things: