Security: Fix critical XSS and HTML injection vulnerabilities#27
Merged
alecdotdev merged 1 commit intoalecdotdev:masterfrom Feb 4, 2026
Merged
Conversation
- Enable Content Security Policy with restrictive rules - Disable unsafe HTML rendering in comrak options - Add DOMPurify sanitization for all rendered HTML content - Prevents script injection and other XSS attack vectors Addresses security vulnerabilities from code audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses critical security vulnerabilities by implementing Content Security Policy, disabling unsafe HTML rendering, and adding comprehensive sanitization.
Changes:
Security Testing:
<img src=x onerror="alert(1)"><script>console.log('xss')</script>Files Modified:
src-tauri/tauri.conf.json- Added CSP configurationsrc-tauri/src/lib.rs- Disabled unsafe HTML renderingpackage.json- Added DOMPurify dependenciessrc/lib/MarkdownViewer.svelte- Added DOMPurify sanitizationDependencies added:
This PR addresses security vulnerabilities identified in code audit and hardens the application against common web attacks.