Remove old interface{} uses and clean up val.Kind() #24
+32
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @alecthomas |
alecthomas
approved these changes
Sep 17, 2025
Owner
|
Nice, thanks! |
Contributor
Author
|
I don't know what to do about those linter warnings. They seem like false positives to me. Also, I cannot merge FYI. |
Owner
|
The linter warnings are not false positives, they're indicating that you need to use The tests are also failing. |
Contributor
Author
|
Sorry. I think it should be fixed now |
Contributor
Author
|
Is this ready to be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some small fixes to clean up and modernise the code.