don't mute connection when listener is absent#8
Open
christian-blades-cb wants to merge 2 commits intoalexcesaro:masterfrom
Open
don't mute connection when listener is absent#8christian-blades-cb wants to merge 2 commits intoalexcesaro:masterfrom
christian-blades-cb wants to merge 2 commits intoalexcesaro:masterfrom
Conversation
Commit removes "quick listener check" which mutes connection and returns error when listener isn't available at the time of inicialization. It seems as this there is no need to scrap connection, because when remote endpoint comes around later, metrics will be received by that endpoint just fine. Fixes alexcesaro#6
* non-listening ports should not cause statsd client to mute
Author
|
@alexcesaro @zstyblik Hopefully a version with passing tests is more palatable. Or at least can spark a conversation. I also would like to remove launch order dependencies. Having the stats emitted and available when the collector finally comes up is the behavior I would expect. |
|
@christian-blades-cb, cool :) |
|
Any estimation when to expect the PR to be merged? |
Author
|
@vchernoy Given that @alexcesaro hasn't pushed any commits since April, it's probably time to either fork this repo or move on to a different one. I chose cactus/go-statsd-client for my recent production work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected tests for #7 to account for expected new behavior.
Fixes #6