Skip to content

Allow passing ForOptions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
annismckenzie wants to merge 1 commit into from
Closed

Allow passing ForOptions #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions reconcilers/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ type ResourceReconciler[Type client.Object] struct {
// +optional
SkipResource func(ctx context.Context, resource Type) bool

// ForOptions is called to build predicates/options passed to the builder's For method.
//
// +optional
ForOptions func() ([]builder.ForOption, error)

Config Config

lazyInit sync.Once
Expand All @@ -137,6 +142,11 @@ func (r *ResourceReconciler[T]) init() {
var nilT T
r.Type = newEmpty(nilT).(T)
}
if r.ForOptions == nil {
r.ForOptions = func() ([]builder.ForOption, error) {
return nil, nil
}
}
if r.Name == "" {
r.Name = fmt.Sprintf("%sResourceReconciler", typeName(r.Type))
}
Expand Down Expand Up @@ -189,9 +199,14 @@ func (r *ResourceReconciler[T]) SetupWithManagerYieldingController(ctx context.C
return nil, err
}

forOptions, err := r.ForOptions()
if err != nil {
return nil, err
}

bldr := ctrl.NewControllerManagedBy(mgr)
if !duck.IsDuck(r.Type, r.Config.Scheme()) {
bldr.For(r.Type)
bldr.For(r.Type, forOptions...)
} else {
gvk, err := r.Config.GroupVersionKindFor(r.Type)
if err != nil {
Expand All @@ -201,7 +216,7 @@ func (r *ResourceReconciler[T]) SetupWithManagerYieldingController(ctx context.C
u := &unstructured.Unstructured{}
u.SetAPIVersion(apiVersion)
u.SetKind(kind)
bldr.For(u)
bldr.For(u, forOptions...)
}

ctx = r.withContext(ctx)
Expand Down
Loading