Skip to content

#73 I fixed the aggrigate_column() typo#105

Open
M-Sidhu25 wants to merge 1 commit intoaliAljaffer:masterfrom
M-Sidhu25:FIXING_AGGREGATE_COLUMN_TYPO
Open

#73 I fixed the aggrigate_column() typo#105
M-Sidhu25 wants to merge 1 commit intoaliAljaffer:masterfrom
M-Sidhu25:FIXING_AGGREGATE_COLUMN_TYPO

Conversation

@M-Sidhu25
Copy link
Contributor

#73 I fixed the typo in src/python/csv_processor.py (line 46), from aggrigate_column() to aggregate_column()

# BUG: Assumes all values are numeric without validation
# BUG: No error handling for non-numeric values
def aggrigate_column(data, column_name):
def aggregate_column(data, column_name):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only keep this change - the other file changes are not necessary

Copy link
Owner

@aliAljaffer aliAljaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the request for changes - we're keeping the 1 issue = 1 pr rule here 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants