Skip to content

chore: avoid redundant IndexDocument construction in heap emplace #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
longway-code wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: avoid redundant IndexDocument construction in heap emplace #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/include/zvec/core/framework/index_document.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,14 +248,16 @@ class IndexDocumentHeap : public ailego::Heap<IndexDocument> {

//! Insert a document into the heap
void emplace(uint64_t key, float score) {
if (score <= threshold_) {
if (score <= threshold_ &&
(!this->full() || score < this->front().score())) {
ailego::Heap<IndexDocument>::emplace(key, score);
}
}

//! Insert a document into the heap
void emplace(uint64_t key, float score, uint32_t index) {
if (score <= threshold_) {
if (score <= threshold_ &&
(!this->full() || score < this->front().score())) {
ailego::Heap<IndexDocument>::emplace(key, score, index);
}
}
Expand Down