feat: Enhanced subplot system, swing markers, and UI improvements#20
Open
mahmutf wants to merge 2 commits intoalihaskar:masterfrom
Open
feat: Enhanced subplot system, swing markers, and UI improvements#20mahmutf wants to merge 2 commits intoalihaskar:masterfrom
mahmutf wants to merge 2 commits intoalihaskar:masterfrom
Conversation
mahmutf
force-pushed
the
feature/labels
branch
from
2c05d07 to
6082954
Compare
New tests added (21 tests, all passing): - Styled overlays: marker, dashed, mixed formats - Grouped subplots: multiple series (e.g., Stochastic %K/%D) - Histogram subplots: _type metadata preservation - DataManager.get_chunk(): styled overlay and grouped subplot slicing - _get_local_ip(): IP detection with fallback chain - plot() host/external_host parameters for Docker support Also fixed: - Import paths updated from src.* to pycharting.* - Updated 3 existing tests to match new styled overlay format Note: 6 pre-existing test failures unrelated to this PR: - test_invalid_index_type, test_ohlc_constraint_*: validation was relaxed - test_repr_with_overlays: __repr__ doesn't show overlay count - test_package_import: src.__version__ never defined These tests were failing before feature/labels branch changes.
mahmutf
force-pushed
the
feature/labels
branch
from
f6cad6f to
94950d6
Compare
Owner
|
in review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for preparing this library. I found it quite useful, and added some items that may be of use to you and others too. Here are the differences:
Subplot System
Additional Style for Markers & Overlays
Bug Fixes
UI Polish