Skip to content

Always round hours down in toSMPTE() (fixes #2) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaCWebDeveloper wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always round hours down in toSMPTE() (fixes #2) #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VideoFrame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ VideoFrame.prototype.toSMPTE = function(frame) {
var fps = this.frameRate;
function wrap(n) { return ((n < 10) ? '0' + n : n); }
var _hour = ((fps * 60) * 60), _minute = (fps * 60);
var _hours = (frameNumber / _hour).toFixed(0);
var _hours = Math.floor(frameNumber / _hour).toFixed(0);
var _minutes = (Number((frameNumber / _minute).toString().split('.')[0]) % 60);
var _seconds = (Number((frameNumber / fps).toString().split('.')[0]) % 60);
var SMPTE = (wrap(_hours) + ':' + wrap(_minutes) + ':' + wrap(_seconds) + ':' + wrap(frameNumber % fps));
Expand Down